spring-ai icon indicating copy to clipboard operation
spring-ai copied to clipboard

Upgrade to Chroma Vector database API v2

Open dev-jonghoonpark opened this issue 10 months ago • 3 comments

ChromaDB 1.0.0 has recently been released.

With this release, the v1 APIs have been completely deprecated. To support the new v2 APIs, we need to upgrade API implementation.

related issues

  • https://github.com/spring-projects/spring-ai/issues/2648
  • https://github.com/spring-projects/spring-ai/issues/2252

dev-jonghoonpark avatar Apr 10 '25 07:04 dev-jonghoonpark

Thank you very much!

markpollack avatar Apr 16 '25 11:04 markpollack

@ilayaperumalg I have completed the rebase to resolve the conflict.

dev-jonghoonpark avatar Apr 16 '25 13:04 dev-jonghoonpark

recently, testcontainers-java 1.21.0 is released this version include support of new version chroma. (related pr: https://github.com/testcontainers/testcontainers-java/pull/10170)

By upgrading the version of testcontainers-java, we can remove the temporal overridden wait strategy in this pr:

static {
    chromaContainer.waitingFor(new AbstractWaitStrategy() {
        @Override
        protected void waitUntilReady() {
            Wait.forHttp("/api/v2/heartbeat");
        }
    });
}

If you want, I can update the PR. But it’s fine to leave it as is.

@ilayaperumalg

dev-jonghoonpark avatar Apr 25 '25 05:04 dev-jonghoonpark

I'm having these issues as well. Any idea when this issue will be merged?

ElishebaW avatar May 01 '25 14:05 ElishebaW

@dev-jonghoonpark Please go ahead and update the PR with your suggestion. @ElishebaW We target to merge this soon and be available for RC1. Thanks for your patience on this.

ilayaperumalg avatar May 01 '25 14:05 ilayaperumalg

@ilayaperumalg Thank you so much!

ElishebaW avatar May 01 '25 14:05 ElishebaW

  • upgraded test-container version for chroma and removed the temporal overridden wait strategy
  • removed @Disabled in ChromaVectorStoreAutoConfigurationIT.addAndSearchWithFilters (related pr: https://github.com/spring-projects/spring-ai/pull/2391)
    • The changes included in this PR seem to fix the issues that were previously present, and everything appears to be working correctly now.

dev-jonghoonpark avatar May 01 '25 21:05 dev-jonghoonpark

@dev-jonghoonpark Thank you once again for the PR upgrading Chroma vector database to use v2 API. Rebased and merged as 09a6a6e1e

ilayaperumalg avatar May 07 '25 13:05 ilayaperumalg