spring-cloud-deployer-kubernetes icon indicating copy to clipboard operation
spring-cloud-deployer-kubernetes copied to clipboard
verified publisher icon spring-cloud

Remove competing auto-config

Open jvalkeal opened this issue 7 years ago • 2 comments

Looks like we try to autoconfigure KubernetesClient which also happens in fabric8.

https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/blob/078cedc3649d857480a0fe6e2de73a91f3b5268f/src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAutoConfiguration.java#L57-L59

https://github.com/fabric8io/spring-cloud-kubernetes/blob/6f3ae54598698e8595fa5d0ad8349ad4bea8cdfb/spring-cloud-kubernetes-core/src/main/java/io/fabric8/spring/cloud/kubernetes/KubernetesAutoConfiguration.java#L75-L78

jvalkeal avatar Mar 13 '18 13:03 jvalkeal

@jvalkeal is this still an issue? @ilayaperumalg had done some work here https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/blob/master/src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAutoConfiguration.java#L63

chrisjs avatar Jun 08 '18 05:06 chrisjs

It is, KubernetesClient is still auto-configured and created from two different places, us and fabric8. Using @AutoConfigureOrder(Ordered.HIGHEST_PRECEDENCE) is kinda hack around it.

jvalkeal avatar Jun 08 '18 07:06 jvalkeal