spring-cloud-dataflow-ui icon indicating copy to clipboard operation
spring-cloud-dataflow-ui copied to clipboard

Hide task definitions that are part of the CTR application from task list page

Open ilayaperumalg opened this issue 6 years ago • 5 comments

The individual task definitions that are part of the CTR can be hidden from the task list page from the UI. This would allow the accidental launch of those applications outside the scope of the CTR.

ilayaperumalg avatar Sep 30 '19 03:09 ilayaperumalg

@ilayaperumalg Instead of doing that on the UI side (which will break the pagination), can we add a parameter in the service (GET /tasks/definitions) to exclude this tasks?

oodamien avatar Sep 30 '19 12:09 oodamien

Yeah, we should not just blindly hide as those are real definitions.

jvalkeal avatar Oct 02 '19 16:10 jvalkeal

And besides, from a task definition point of view, we don't have info about parent definition so relying on a prefix just won't work. i.e. task, task-t1 and task-t2. If you then create a separate task task-xxx there's no way to know unless you start to do a complex analysis of all existing task defs. Don't think we wanna go down that route.

jvalkeal avatar Oct 02 '19 16:10 jvalkeal

This requires adjustments to the server-side API.

sabbyanandan avatar Oct 21 '19 18:10 sabbyanandan

Doing this in the GUI will be expensive. We need the API to return the root-level Task definition, and children attached to it. We can then TREE it on the GUI eventually.

sabbyanandan avatar Aug 25 '21 16:08 sabbyanandan