spring-cloud-contract icon indicating copy to clipboard operation
spring-cloud-contract copied to clipboard

Autoconfigure default MessageVerifierReceiver and MessageVerifierSender implementations for Kafka

Open OlgaMaciaszek opened this issue 2 years ago • 6 comments

OlgaMaciaszek avatar Apr 26 '23 16:04 OlgaMaciaszek

The former implementation was deleted in commit: fa51d6a076be8c5dc620ea6e226ad6c87dc2c0ac Maybe by a mistake? @marcingrzejszczak

AdrianHarenczyk avatar Dec 28 '23 08:12 AdrianHarenczyk

No, we removed all the mock versions of receivers. This issue is about doing autoconfigs like the ones created here or here.

marcingrzejszczak avatar Dec 28 '23 09:12 marcingrzejszczak

So the issue is currently, that Kafka has no implementation to verify contracts. The developer adding 'org.springframework.cloud:spring-cloud-starter-contract-verifier' needs to write his own implementation of Receivers, as they are gone, and there is no notice about it. They are gone from version 4 at least, so people migrating to spring boot 3.2 need to also write their own implementation of kafka KafkaStubMessages because without it all their contract tests related to kafka fail. If that is just what was intended, please point me to the place where those crucial parts of the code are implemented, as otherwise I need to just write that part on my own. image Here is the stack issue about it: https://stackoverflow.com/questions/77661101/spring-boot-3-migration-spring-cloud-starter-contract-verifier-and-messageverifi

AdrianHarenczyk avatar Dec 28 '23 09:12 AdrianHarenczyk

That's correct, we write about this in the migration path

marcingrzejszczak avatar Dec 28 '23 13:12 marcingrzejszczak

Thanks a lot, that is pretty much clear now.

AdrianHarenczyk avatar Dec 29 '23 06:12 AdrianHarenczyk

hello, is there any plans to implement this feature? it would be nice if spring itself can provide a real kafka based verifier.

fatihdogmus avatar May 14 '24 06:05 fatihdogmus