spring-cloud-consul icon indicating copy to clipboard operation
spring-cloud-consul copied to clipboard
verified publisher icon spring-cloud

Reinstate tags-as-metadata adding option to merge tags. Fixes #699

Open hamigam opened this issue 4 years ago • 2 comments

Picking up the work from https://github.com/spring-cloud/spring-cloud-consul/pull/700

I've brought back the missing constructor as mentioned in the review comments of PR 700. Additionally I've added support to start reading isSecure from tags when enabled - for full backwards compatibility.

I did not address the comments around ConfigServer - I see this PR as a compatibility bridge for services already deployed with older versions of Spring Boot, I see current scope of changes sufficient to achieve this goal?

Please be gentle, my first contribution to Spring.

hamigam avatar Apr 06 '22 21:04 hamigam

@spencergibb @ryanjbaxter could you guys have a look? Adding this backwards compatibility would help to upgrade Spring Boot in large enterprise deployments and, for example, cleanly remediate recently popular CVE-2022-22965. Thanks!

hamigam avatar Jun 10 '22 19:06 hamigam

Any progress here? @spencergibb I will close #700 in favor of this one.

lucasoares avatar Apr 27 '23 00:04 lucasoares