spring-cloud
Detect dynamic mgmt port. Fixes gh-561
Ignoring the checkstyle auto-fixed whitespace changes, see:
- spring-cloud-commons/src/main/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistration.java - Capture management web server init event & wait for ApplicationReadyEvent before starting registration (to ensure that http & optional mgmt ports have been discovered)
- spring-cloud-commons/src/test/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistrationMgmtDisabledTests.java - updated correct property for mgmt port
- spring-cloud-commons/src/test/java/org/springframework/cloud/client/serviceregistry/AbstractAutoServiceRegistrationTests.java - updated correct property for mgmt port
@spencergibb - so what am i doing wrong when running mvn install, as that appears to be the cause of the re-formatting. I'll revert the whitespace changes
Reverted via 4995ffc88adb2e867289c6694113c72d7dd7fe30.
In spring-cloud-consul, tests started failing as start() was called before bind().
Hi! As you probably know, this PR introduces some breaking changes. Our academic tool, BreakBot, helps developers better assess the impact of these changes on client projects. BreakBot checked the top 100 most starred clients of spring-cloud-commons on GitHub and found out that only one (indeed spring-cloud-consul) is impacted by one of the breaking changes.
You can find the full BreakBot report in our fork repository breakbot-playground/spring-cloud-commons.
We hope this information about the impact of this PR's changes is valuable to you, and apologize otherwise. If you're willing to help, we would kindly ask for your help to fill in a 5-minutes survey about the report. Your feedback will help us improve the tool and help us in our research!
@lmove please stop adding these comments across spring cloud projects.
Hi @spencergibb, didn't mean to bother you. As stated in my comment, this is part of our research to support OSS projects and we just wanted to know if the BreakBot reports could be useful for library maintainers. It was not our intention to bother you. Sorry if that was the case. Following your reaction, we will take out all spring-cloud projects from the reports generation and won't consider them in our survey. Have a good day.