spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

SimpleMessageListenerContainerFactory doesn't propagate queueMessageHandler field when SimpleMessageListenerContainer bean is created via createSimpleMessageListenerContainer

Open setu9760 opened this issue 4 years ago • 0 comments

Type: Bug

Component: SQS messaging

Describe the bug SimpleMessageListenerContainerFactory has queueMessageHandler field and has setter for this. However when public method createSimpleMessageListenerContainer is called to create the actual bean SimpleMessageListenerContainer this field is not propagated. Ideally for the factory bean we would want all the relevant properties/fields propagated to the underlying bean without having to manually inject it twice in factory and then the underlying bean.

Sample

@Bean
@Primary
public SimpleMessageListenerContainerFactory simpleMessageListenerContainerFactory(
    QueueMessageHandler queueMessageHandler, AmazonSQSAsync amazonSqs) {
  var factory = new SimpleMessageListenerContainerFactory();
  factory.setQueueMessageHandler(queueMessageHandler);
  factory.setAmazonSqs(amazonSqs);
  factory.setAutoStartup(true);
  factory.setMaxNumberOfMessages(1);
  return factory;
}

@Bean
@Primary
public SimpleMessageListenerContainer simpleMessageListenerContainer(
    SimpleMessageListenerContainerFactory simpleMessageListenerContainerFactory,
    QueueMessageHandler queueMessageHandler) {
  var simpleMessageListenerContainer= simpleMessageListenerContainerFactory.createSimpleMessageListenerContainer();
  simpleMessageListenerContainer.setMessageHandler(queueMessageHandler);
  return simpleMessageListenerContainer;
}

in the above code the simpleMessageListenerContainer.setMessageHandler(queueMessageHandler); line shouldn't be required and the call simpleMessageListenerContainerFactory.createSimpleMessageListenerContainer() should ensure all fields from factory are injected into the bean.

setu9760 avatar Nov 02 '21 11:11 setu9760