github-java-client icon indicating copy to clipboard operation
github-java-client copied to clipboard

feat: Add OpenTelemetry Support

Open Abhi347 opened this issue 1 year ago • 1 comments

feat: Add OpenTelemetry Support feat: Add Support for Tracing Propagation Headers

Abhi347 avatar Sep 17 '24 13:09 Abhi347

Codecov Report

Attention: Patch coverage is 74.82993% with 111 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (8ddc6d0) to head (331caad). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 75.08% 63 Missing and 7 partials :warning:
...fy/github/tracing/opencensus/OpenCensusTracer.java 43.24% 21 Missing :warning:
...java/com/spotify/github/v3/clients/NoopTracer.java 65.00% 7 Missing :warning:
...n/java/com/spotify/github/tracing/TraceHelper.java 78.57% 3 Missing :warning:
...hub/tracing/opentelemetry/OpenTelemetryTracer.java 91.17% 2 Missing and 1 partial :warning:
...in/java/com/spotify/github/tracing/BaseTracer.java 83.33% 2 Missing :warning:
...tify/github/tracing/opencensus/OpenCensusSpan.java 90.00% 2 Missing :warning:
...ithub/tracing/opentelemetry/OpenTelemetrySpan.java 90.00% 2 Missing :warning:
...om/spotify/github/opencensus/OpenCensusTracer.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     77.71%   76.89%   -0.83%     
- Complexity      349      381      +32     
============================================
  Files            50       56       +6     
  Lines          1149     1277     +128     
  Branches         46       51       +5     
============================================
+ Hits            893      982      +89     
- Misses          226      264      +38     
- Partials         30       31       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 17 '24 13:09 codecov[bot]

It's a bit unclear from you description whether this is a breaking change or not? I guess we don't want any breaking changes but add opentelemetry support? Is that what you mean by this?

dennisgranath avatar Mar 10 '25 14:03 dennisgranath

It's a bit unclear from you description whether this is a breaking change or not? I guess we don't want any breaking changes but add opentelemetry support? Is that what you mean by this?

@dennisgranath It's not breaking change anymore since I have added the duplicated classes at their previous position and marked them as deprecated. I'll verify tomorrow if this is still going to cause some issues. Updating the description accordingly.

Update: Confirmed that it's not a breaking change.

Abhi347 avatar Mar 10 '25 16:03 Abhi347