HubFramework icon indicating copy to clipboard operation
HubFramework copied to clipboard

Move layout logic into the collection view factory

Open cerihughes opened this issue 9 years ago • 2 comments

Create a collection view layout in the collection view factory when we create the collection view, and absolve the view controller of that responsibility. The VC now also doesn't need to create a "temporary" UICollectionViewLayout class for the collection view.

cerihughes avatar Apr 12 '17 13:04 cerihughes

3 Messages
:book: Executed 383 tests, with 0 failures (0 unexpected) in 6.960 (7.509) seconds
:book: Executed 379 tests, with 0 failures (0 unexpected) in 6.604 (7.246) seconds
:book: Executed 11 tests, with 0 failures (0 unexpected) in 212.274 (212.282) seconds

Generated by :no_entry_sign: Danger

spotify-ci-bot avatar Apr 12 '17 13:04 spotify-ci-bot

Codecov Report

Merging #331 into master will decrease coverage by 0.37%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #331      +/-   ##
=========================================
- Coverage   80.57%   80.2%   -0.38%     
=========================================
  Files          84      84              
  Lines        5659    4500    -1159     
=========================================
- Hits         4560    3609     -951     
+ Misses       1099     891     -208
Impacted Files Coverage Δ
...rces/HUBViewControllerExperimentalImplementation.m 4.68% <ø> (-0.13%) :arrow_down:
sources/HUBViewControllerImplementation.m 88.3% <ø> (-1.82%) :arrow_down:
sources/HUBConfigViewControllerFactory.m 96.66% <100%> (-0.71%) :arrow_down:
sources/HUBViewControllerFactoryImplementation.m 100% <100%> (ø) :arrow_up:
sources/HUBCollectionViewFactory.m 100% <100%> (ø) :arrow_up:
sources/HUBLiveServiceFactory.m 75% <0%> (-5%) :arrow_down:
sources/HUBComponentUIStateManager.m 85.71% <0%> (-3.18%) :arrow_down:
sources/HUBLiveServiceImplementation.m 81.39% <0%> (-2.92%) :arrow_down:
sources/HUBIdentifier.m 91.66% <0%> (-2.09%) :arrow_down:
sources/HUBCollectionContainerView.m 90.9% <0%> (-1.95%) :arrow_down:
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84a7b19...f679dfc. Read the comment docs.

codecov-io avatar Apr 12 '17 15:04 codecov-io