Gallery icon indicating copy to clipboard operation
Gallery copied to clipboard

Fix toBoolean to allow `false`

Open Cipa opened this issue 14 years ago • 3 comments

Fix to toBoolean - Allows the use property =false instead of property=0 Fix to support 'true' when passed as a string. For some reason 'true' came out as an empty string which is false

Cipa avatar Apr 22 '11 18:04 Cipa

Colorbox Plugin Support: http://colorpowered.com/colorbox/ http://modxrules.com/revo/demo/colorbox-gallery.html

Supported settings - in [] supported values

theme => theme1 [choose from theme1 to theme5] transition => elastic [elastic,fade,none] speed => 350 width => false height => false maxWidth => false maxHeight => false opacity => 0.85 loop => true slideshow => false slideshowSpeed => 2500 slideshowAuto => true slideshowStart => 'start slideshow' slideshowStop => 'stop slideshow' current => 'image {current} of {total}' previous => 'previous' next => "next" close => "close" colorboxUseCss => true colorboxUseJs => true

Example:

[[!Gallery? &toPlaceholder=gallery &album=Test &plugin=colorbox &theme=theme5 &transition=fade &speed = 100 &opacity = 0.3 &slideshow = true &loop = false ]] [[+gallery]]

Cipa avatar Apr 23 '11 18:04 Cipa

Cipa, is this still in any way a valid pull request for the original subject—"Fix toBoolean to allow false" ?

opengeek avatar Jan 30 '13 20:01 opengeek

Thanks @Cipa. Got this in a testing branch over at modxcms/Gallery. Just want to make sure Colorbox isn't already outdated since this PR got so stale.

https://github.com/modxcms/Gallery/commit/9c9213ac8dbff22cd9d9f7276c65f8c6b77ed331

jpdevries avatar Oct 01 '13 23:10 jpdevries