php-client
php-client copied to clipboard
fix: incorrect arg count local mode
PHP SDK
What did you accomplish?
Resolved an incorrect argument count when constructing SplitView inside LocalhostSplitManager.
This was a 100% failure rate code path that made local mode impossible to use in 7.3.0 (haven't validated earlier versions, but the line was committed 21 months prior).
How do we test the changes introduced in this PR?
A new test was added to the tests suite. This ensure the failure mode does not exist and serves as a regression test for LocalhostSplitManager going forward.
Extra Notes
Closes #240.