javascript-client icon indicating copy to clipboard operation
javascript-client copied to clipboard

Redis URL configuration overridden by undocumented env vars

Open jordan-lantz opened this issue 10 months ago • 1 comments

https://github.com/splitio/javascript-client/blob/development/src/settings/storage/node.js#L25-L45

The use of the REDIS_* env vars is not mentioned on the Node.js SDK. Guess what I had named the env vars that my app was using for its own Redis connection :cry: Arguably this logic should be inverted, so the env vars would not override the config, or update their names to be less likely to conflict with existing env vars (e.g. SPLIT_REDIS_URL)

Also it would be really nice if enabling debug logging included some logging from the Redis client, or update the docs to suggest setting export DEBUG=ioredis:* to troubleshoot redis issues

jordan-lantz avatar Mar 12 '25 14:03 jordan-lantz

Hi @jordan-lantz,

Thank you for your feedback. We will take your suggestions into account when updating the public documentation. Regarding the proposed updates (renaming the environment variables and revisiting their precedence), we’ll need to discuss them with the team to consider for a future major release.

We can keep this issue open until we have a final decision or update the documentation accordingly.

EmilianoSanchez avatar Mar 28 '25 15:03 EmilianoSanchez