harold icon indicating copy to clipboard operation
harold copied to clipboard

Code Freeze salon topic is overly verbose

Open jewel-andraia opened this issue 6 years ago • 4 comments

image (4)

harold set the channel topic: ❄️ CODE FREEZE -- No deploys (DEPLOYS ARE ON HOLD - deploy freeze for Pre-Holiday Bugfixes is now in effect. More details on http://tiny.cc/06kzcz (Mr. Freeze: https://gph.is/1eMBXxy)) | @andytuba has the :conch: | no active deploys | queue

This topic gets so long that it's a little unusable, particularly if anyone is queued.

jewel-andraia avatar Dec 18 '19 18:12 jewel-andraia

❄️ CODE FREEZE -- No deploys

This preamble comes from code:

https://github.com/spladug/harold/blob/7948fb79f3a6ed7f010325925e65a9de4118c05e/harold/plugins/deploy.py#L278-L281

jewel-andraia avatar Dec 18 '19 18:12 jewel-andraia

That preamble could be reduced to:

:snowflake: DEPLOY FREEZE

jewel-andraia avatar Dec 18 '19 18:12 jewel-andraia

DEPLOYS ARE ON HOLD - deploy freeze for Pre-Holiday Bugfixes is now in effect. More details on http://tiny.cc/06kzcz (Mr. Freeze: https://gph.is/1eMBXxy)

This current_hold messaging probably comes from the Google Apps Script which backs the Google Form. In the context of the salon topic, there are redundancies which could be improved.

jewel-andraia avatar Dec 18 '19 18:12 jewel-andraia

The current_hold message sent by the script could be reduced to the bare minimum. Although I mourn the loss of the "Mr. Freeze" styling, I'd favor simplicity and functionality over style.

For example:

Pre-Holiday Bugfixes :calendar: http://tiny.cc/06kzcz

jewel-andraia avatar Dec 18 '19 18:12 jewel-andraia