spin icon indicating copy to clipboard operation
spin copied to clipboard

fix(azureOauth2): fixed oauth2 auth for azure custom config support

Open gsapkal opened this issue 5 years ago • 4 comments

Updated the oauth2 to work with azure oauth2 custom config, Added support for AuthCodeOptions options in config. Updated the auth workflow to open default browser with auth url. No need to copy past url and code from oauth2 redirect response. If the default browser doesn't work this fallbacks to printing url on console with instruction.

gsapkal avatar Sep 10 '20 22:09 gsapkal

Hi! When this PR will be merged? Looking forward for it!

ElenaForester avatar Sep 14 '20 10:09 ElenaForester

Hi, is there a linked bug that would describe the behavior you're fixing? Does your config file still look like for what we have for example oauth: https://github.com/spinnaker/spin/blob/master/config/example.yaml#L25? I don't have experience with spin CLI and authenticating to azure so a little more context could help the review process, thanks!

Chinikins avatar Dec 14 '20 22:12 Chinikins

Hi, is there a linked bug that would describe the behavior you're fixing? Does your config file still look like for what we have for example oauth: https://github.com/spinnaker/spin/blob/master/config/example.yaml#L25? I don't have experience with spin CLI and authenticating to azure so a little more context could help the review process, thanks!

@Chinikins I have updated example config. This PR enables the advanced config for Oauth2. These are needed based on organizations oauth2 config.

gsapkal avatar Dec 15 '20 03:12 gsapkal

@gsapkal could you please resolve conflicts?

Chinikins avatar Nov 12 '21 23:11 Chinikins