orca icon indicating copy to clipboard operation
orca copied to clipboard

chore(lambda): rewrite to use Kato/Oort

Open mattgogerly opened this issue 2 years ago • 4 comments

As promised, cleaning up the Lambda stages to use Kato/Oort rather than directly calling Clouddriver. Couple of other bits of cleanup too.

  • Use Kato to request Lambda ops and check status
  • Use Oort to get Lambdas from cache
  • Use existing stage.mapTo() to map context to classes rather than custom util
  • Use builders rather than setting properties
  • Use HttpStatus enum rather than magic numbers

mattgogerly avatar Jul 27 '23 07:07 mattgogerly

Hey @mattgogerly. Thanks for taking this on! Is your overall intent with this PR to move capabilities currently in the Lambda Plugin natively into OSS so we can deprecate the plugin?

Is there anything in the plugin that you are not planning on replacing?

Do you think additional related PRs will need to be created in addition to this one?

kyledmitchell avatar Jul 31 '23 17:07 kyledmitchell

Hey @mattgogerly. Thanks for taking this on! Is your overall intent with this PR to move capabilities currently in the Lambda Plugin natively into OSS so we can deprecate the plugin?

Is there anything in the plugin that you are not planning on replacing?

Do you think additional related PRs will need to be created in addition to this one?

The plugin code was moved into Orca in https://github.com/spinnaker/orca/pull/4449.

This PR rewrites that code to use Kato/Oort.

mattgogerly avatar Aug 01 '23 19:08 mattgogerly

@mergifyio update

dbyron-sf avatar Sep 27 '24 20:09 dbyron-sf

update

☑️ Nothing to do

  • [ ] -conflict [📌 update requirement]
  • [X] #commits-behind > 0 [📌 update requirement]
  • [X] -closed [📌 update requirement]
  • [X] queue-position = -1 [📌 update requirement]

mergify[bot] avatar Sep 27 '24 20:09 mergify[bot]