Aaron Crickenberger
Aaron Crickenberger
ref: https://github.com/kubernetes/test-infra/issues/18801 (covered slack mergewarning plugin)
/milestone v1.23 /remove-lifecycle stale I think what is keeping this open is that we are waiting to run down the deprecation clock so we can remove the old fields
Deprecation date has passed, if someone is interested in removing support for the old fields as documented here: https://github.com/kubernetes/test-infra/blob/530961d60201d967c9123baa2089045870344bc2/prow/ANNOUNCEMENTS.md#L184-L187
/close Closing as https://github.com/kubernetes/k8s.io/pull/3407 has been closed
/cc @andyzhangx @msau42 per https://github.com/kubernetes/test-infra/pull/25547#issuecomment-1240872460
FWIW this was fixed by https://github.com/kubernetes-sigs/kubetest2/pull/206 if you want to un-pin
FWIW SIG Kind isn't really a thing, kind is technically a subproject of Kubernetes SIG Testing (ref: https://github.com/kubernetes/community/tree/master/sig-testing#subprojects). But yes wholeheartedly behind this request as one of SIG Testing's chairs
(btw thank you for breaking this up into commits the way you did, that really helped make this more digestible)
``` test/e2e/kubectl/kubectl.go:1948:14: undefined: framework.RunKubectlOrDie test/e2e/kubectl/kubectl.go:1958:24: undefined: framework.RunKubectlOrDie test/e2e/kubectl/kubectl.go:1965:23: undefined: framework.RunKubectlOrDie ``` Looks like this will need another rebase
Just to give PR authors a heads up in case this caused a merge-conflict, this is a naive "do they touch the same files" list of open PR's that might...