java-spiffe icon indicating copy to clipboard operation
java-spiffe copied to clipboard

The java-spiffe modules contain split packages which break the Java Modules (JPMS)

Open thomasrichner-oviva opened this issue 3 years ago • 0 comments

The Java Platform Module System (JPMS) introduced in Java 9 does not allow for split-packages. That is the same package in multiple JARs.

As a matter of fact java-spiffe has some split packages though, this breaks libraries that want to write modules depending on java-spiffe.

At least one of the offending packages leads to a compilation error: the unnamed module reads package io.spiffe.workloadapi.internal from both grpc.netty.macos.aarch64 and java.spiffe.core

Ideally the split package is removed by e.g. moving io.spiffe.workloadapi.internal in grpc.netty.macos.aarch64 to io.spiffe.workloadapi.grpc.netty.macosa.arch64.internal or similar.

Even better would be to define a proper java module for java-spiffe e.g. write a module-info.java file. This would also prevent future introduction of split packages.

thomasrichner-oviva avatar Jan 12 '23 09:01 thomasrichner-oviva