cli icon indicating copy to clipboard operation
cli copied to clipboard

[Popup Lyrics] Japanese and Korean lyrics transliteration

Open surya27895 opened this issue 2 years ago • 6 comments

📝 Provide a description of the new feature

well, since spicetify has this features on lyrics plus, I think it will be great if can also implement on popup lyrics

➕ Additional Information

No response

surya27895 avatar Jun 01 '23 14:06 surya27895

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Patrick-orz avatar Sep 17 '23 04:09 Patrick-orz

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

surya27895 avatar Sep 17 '23 04:09 surya27895

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

I wonder if it worked for you?

Patrick-orz avatar Sep 17 '23 13:09 Patrick-orz

For people looking at this issue, the following repo might suit your needs: Patrick-orz/PopupLyrics-Plus

Wow thanks!! I will give it try

I wonder if it worked for you?

it works, but still buggy and caused few crash, memory leak I guess? I think I will wait until few updates more, ah and it not work as I expected, I hope language detection can work automatically, but great job for initial release!!! hope the development will continue.

surya27895 avatar Sep 17 '23 14:09 surya27895

Adding translator to popupLyrics will make the readability of the code much worse because we're limited to one file. PopupLyrics are somewhat intended to be lightweight. I understand that you want to see this feature but unfortunately I did not see people asking for this so I don't know if it's really needed?

rxri avatar Nov 12 '23 00:11 rxri

It is not transliteration it is translation

ok-coder1 avatar Feb 21 '24 13:02 ok-coder1