tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

BugFix : Removing case sensitivity of licenseIds

Open puneeth072003 opened this issue 2 years ago • 8 comments

This PR fixes the issue #165 from ntia-conformance-checker repo.

puneeth072003 avatar Dec 31 '23 05:12 puneeth072003

Can you please also add tests to show and test the new behaviour?

maxhbr avatar Jan 02 '24 10:01 maxhbr

As this is also relevant for matching and relating licenseRefs, I assume that this also needs changes beyond the validation layer.

maxhbr avatar Jan 02 '24 14:01 maxhbr

Can you please also add tests to show and test the new behaviour?

Sure....but it can take a while Tad busy at the moment

I'll add them by this weekend

puneeth072003 avatar Jan 02 '24 14:01 puneeth072003

@puneeth072003 , do you plan to continue on that topic? I think this is a helpful and important feature, but a consistent and complete implementation is necessary

maxhbr avatar Mar 22 '24 16:03 maxhbr

@maxhbr sure I'd like to continue

puneeth072003 avatar May 02 '24 03:05 puneeth072003

Hi @puneeth072003, are you still working on this? Otherwise I can take over from you if you like.

armintaenzertng avatar Aug 09 '24 13:08 armintaenzertng

@armintaenzertng yep sure! I'm lil preoccupied at the moment you can take over this one

puneeth072003 avatar Oct 07 '24 07:10 puneeth072003

Hi, Is there any update on this one? Was hoping to get a fix for the same issue: https://github.com/spdx/tools-python/issues/810

rtabassum avatar Oct 28 '24 16:10 rtabassum