dace icon indicating copy to clipboard operation
dace copied to clipboard

OTFMapFusion: Support for WCR, nested maps & connector renaming fixed

Open lukastruemper opened this issue 3 years ago • 1 comments

This PR fixes several minor bugs in OTFMapFusion around

  • correctly re-naming connectors
  • correctly connecting memlets to new tmp data
  • correctly inferring the mapping of first map's parameters and second maps' parameters

that both me and Phil saw on specific examples like hdiff.

But importantly however, this PR enables OTFMapFusion to be applied on a specific set of maps with WCR. I am sure that it works but I need a second transformation InlineNestedReduce to write tests for it efficiently. I will open a second PR for the other transformation (or extend an existing one) and then add another PR for the additional tests

lukastruemper avatar Aug 23 '22 08:08 lukastruemper

Only minor comments remain, otherwise LGTM!

Pushed the fixes

lukastruemper avatar Nov 07 '22 12:11 lukastruemper