QuaRot icon indicating copy to clipboard operation
QuaRot copied to clipboard

Question about reproducing Fig.1

Open xinghaow99 opened this issue 1 year ago • 1 comments

Hi! Thanks for the great work!

Been playing with the code today and trying to reproduce Figure 1 in the paper, and here's what I got. image

I noticed that the activations after rotation have a larger norm, which does not match the case in Figure 1.

I'm wondering if this is the case or maybe I missed something.

Thanks!

xinghaow99 avatar May 14 '24 21:05 xinghaow99

Here is my code.

xinghaow99 avatar May 14 '24 22:05 xinghaow99

Thanks @xinghaow99

I think the whole point is about scaling and you can try to scale the distribution using a single number (maybe divide them with the maximum value).

sashkboos avatar Jun 06 '24 15:06 sashkboos

Thank you for your response. @sashkboos

I get the idea now. Just to make sure that incoherent processing does affect the norm of the matrix, right? And did you apply any scaling when plotting Fig.1?

xinghaow99 avatar Jun 07 '24 09:06 xinghaow99

@xinghaow99

Yes. We only care about the dynamic range during quantization.

sashkboos avatar Jun 12 '24 08:06 sashkboos