Benedikt Franke

Results 536 comments of Benedikt Franke

I see, so there is no version detection magic going on. We are extending the Symfony config, which explains why this change broke our project. Thank you for the response.

Please refrain from calling missing features bugs or categorizing them as such. According to the Lighthouse documentation, entity resolvers only receive a single argument: - https://lighthouse-php.com/master/federation/reference-resolvers.html#single-entity-resolvers - https://lighthouse-php.com/master/federation/reference-resolvers.html#batched-entity-resolvers This has...

> it would be awesome if it's possible to attach custom attributes to field definition You can, the `array $config` passed in `\GraphQL\Type\Definition\FieldDefinition::__construct` is stored in a public property unchanged....

Perhaps you can propose a pull request to fix 1.? And in regards to 2., strong typing won't be possible either way - you can ignore PHPStan errors though.

How would this work when it comes to nested mutations?

> Is there anything holding us back to do the same thing for update and upsert in a nested mutation that I am missing? We haven't implemented filtering of any...

@sweet-greg the particular use case you have makes sense. From a library perspective, i am thinking about how this feature can be generalized and made extensible.

I am currently working on leveraging builder enhancement for `@delete`, `@forceDelete` and `@restore` in https://github.com/nuwave/lighthouse/pull/2289 and could see the same change for `@update`, `@upsert` and nested mutations. The basic idea...

I would not mind the addition of a `scopes` argument to `@update`. Feel free to create a PR. It does not have to be included in the first draft, but...

This issue was uncovered in https://github.com/nuwave/lighthouse/pull/1915 and has not been fixed yet, see https://github.com/nuwave/lighthouse/blob/26c25e9eadd0b5aecdd637a84354b82d93e2e9bd/tests/Integration/Schema/Directives/WithDirectiveTest.php#L306-L308. https://github.com/nuwave/lighthouse/issues/1873 is related, it is probably a good idea to work on both issues at once.