Benedikt Franke comments

Results 536 comments of


                                            Benedikt Franke

Select only necessary columns for optimized queries

Right now, two pull requests are trying to solve this issue: - https://github.com/nuwave/lighthouse/pull/1626 is following a relatively simple approach but lacks tests - https://github.com/nuwave/lighthouse/pull/2235 tries to do more magic, which...

Mutate multiple models at once

`@delete` already accepts a list of IDs and will become even more flexible with https://github.com/nuwave/lighthouse/pull/2289.

"Internal server error" when client send invalid query with unknown type

@videni no, it is too complicated and involves subtle breaking changes.

"Internal server error" when client send invalid query with unknown type

This is fixed in `master` right now and will be released when v6 is ready.

Pass the path array to the `key` method of `CacheKeyAndTags` class

Please update this merge request with the latest changes from `master`. I just made the cut to work towards the upcoming v6.

Pass the path array to the `key` method of `CacheKeyAndTags` class

Missing Changelog. Also, why do you want to make this change at all, what is the use case?

@whereAuth directive doesn't return pivot of linked relationship

Closing due to lack of reproducibility.

Switch test setup to MySQL 8

Should we actually do this though? I can not find other sources, but at least in 2019 the most popular version was still 5.7 - see https://www.eversql.com/mysql-8-adoption-usage-rate.

@restore truncating the global ID for the returned data

Closing due to lack of a reproducible test case. Feel free to add a pull request that adds a missing test.

Drop support for unsupported Laravel and PHP versions

6.x is going to require Laravel 9 and PHP 8.