parserz icon indicating copy to clipboard operation
parserz copied to clipboard

Experiment - eliminate creation of nested tuples

Open sergei-shabanau opened this issue 5 years ago • 1 comments

Connects #75

Ultimately I am pursuing the following flow:

  1. Have user-defined AST1 in terms of Grammar.GADT
  2. Rewrite / Optimize AST1 into another AST2 expressed as low level GADT
  3. Compile resulting AST2 into parser/printer functions

My biggest concern is the lost type safety at step 2 with my current approach, thus I'd like to get some advise with implementation approach I am taken.

I've added inline comments to ease the discussion.

sergei-shabanau avatar Mar 25 '20 19:03 sergei-shabanau

Codecov Report

Merging #78 into master will decrease coverage by 8.19%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #78      +/-   ##
===========================================
- Coverage   100.00%   91.80%   -8.20%     
===========================================
  Files            3        3              
  Lines          269      293      +24     
  Branches         5        6       +1     
===========================================
  Hits           269      269              
- Misses           0       24      +24     
Impacted Files Coverage Δ
...ain/scala/org/spartanz/parserz/ParsersModule.scala 90.87% <0.00%> (-9.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 459cdb9...7139c68. Read the comment docs.

codecov-io avatar Mar 25 '20 21:03 codecov-io