spark_api icon indicating copy to clipboard operation
spark_api copied to clipboard

WIP: v2 changes

Open bhornseth opened this issue 7 years ago • 1 comments

this will probably be a long-running PR while I tie up all the loose ends I'm hoping to tie up, but I figured I'd throw this up and let TravisCI run the tests while I tinker.

I started a v2.0 milestone a while ago with some goals, but in general, I'm looking to get all the dependencies up to date, make some breaking changes (e.g. merge the ListingCart / Collection models) that have been on the roadmap for a while, and collect a number of new models from our internal codebases that can be extracted here.


closes #131 closes #133 closes #139

bhornseth avatar Jun 27 '18 01:06 bhornseth

I aimed to keep all the commits small. They're all basically one change, though dba8bdf was a very large commit due to switching all the existing specs to the Rspec 3 DSL syntax. I followed the official guide for that, including using the transpec gem to auto-convert the specs, which worked shockingly well.

bhornseth avatar Jun 27 '18 13:06 bhornseth