app icon indicating copy to clipboard operation
app copied to clipboard

Spacemesh api mock [WIP]

Open ImmanuelSegol opened this issue 7 years ago • 1 comments

  • [x] Post a Transaction
  • [x] Get Address Balance
  • [x] Retrieving an address transactions
  • [x] Buy SMC from exchanges
  • [x] Get SMC current price
  • [x] Get transaction status by TX id

This is just a draft. I have some questions @avive @iamonuwa :

  • Is the general implementation pattern proper, and what you guys where thinking of ?

  • Should I add auto-fix to TSlint? And why are there lint rules that wont allow me to use a type for Transaction but instead request a interface

  • Could you provide some better mock data and structure for example how should buySMCFromExchange work exactly should it search for the cheapest price on a list of exchanges or should it let the user specify the exchange with some sort of ID?

Closes #28

ImmanuelSegol avatar Oct 23 '18 07:10 ImmanuelSegol

@avive @samparsky I will make the changes thanks for the review. What else should I improve/add/change?

ImmanuelSegol avatar Oct 26 '18 13:10 ImmanuelSegol