spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Update paths to show correctly on windows

Open waydeb opened this issue 3 years ago • 6 comments

Updated this file so that file paths are correct on windows.

Added an if else statement to check if the system is Win32 and if so change the full path from x/x to x\x to conform with windows file paths

waydeb avatar Jun 24 '22 12:06 waydeb

@waydealphax is attempting to deploy a commit to the Spacedrive Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 24 '22 12:06 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
spacedrive-storybook ✅ Ready (Inspect) Visit Preview Jul 4, 2022 at 10:35AM (UTC)

vercel[bot] avatar Jun 24 '22 12:06 vercel[bot]

@maxichrome looks fine to me now, have a check and lmk

waydeb avatar Jul 04 '22 05:07 waydeb

looks fine to me now, have a check and lmk

still includes lots of unrelated changes. any way you can base this on main / mark it as a draft PR until the related changes are merged in?

maxichrome avatar Jul 04 '22 07:07 maxichrome

ive rebased on the latest main and made changes where needed (i removed rust fix because it appears to no longer show incorrectly or atleast for me)

waydeb avatar Jul 04 '22 09:07 waydeb

Thanks for the PR but I don't think in its current form we will want to merge it. To fix this issue work will need to be done on the Rust backend to properly understand the operating system the file was created on and return the correct path. The current fix in this PR will break when it comes to hooking the app up to the P2P sync layer because it uses the OS your running the app on (appProps.platform) to decide how to display the path instead of the operating system of the computer the file was created on.

oscartbeaumont avatar Aug 30 '22 06:08 oscartbeaumont