java icon indicating copy to clipboard operation
java copied to clipboard
verified publisher icon sous-chefs

AdoptOpenJDK --> Termurin/Semeru

Open damacus opened this issue 3 years ago • 1 comments

Description

Remove AdoptOpenJDK and replace with Adoptium Termurin & IBM Semeru

Issues Resolved

#674

Check List

  • [ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented in the README if applicable.

damacus avatar May 18 '22 18:05 damacus

:cold_sweat: RSpec failure

48 examples, 1 failure
Example Description Message
./spec/libraries/openjdk_helpers_spec.rb:32 Java::Cookbook::OpenJdkHelpers#default_openjdk_url Invalid OpenJDK version should raise an error expected Exception with "Version supplied does not have a download URL set" but nothing was raised

github-actions[bot] avatar May 18 '22 18:05 github-actions[bot]

Released as: 12.0.0

kitchen-porter avatar Sep 29 '23 14:09 kitchen-porter

@xorima why did you merge this when it has broken tests. on a friday too....

yacn avatar Sep 29 '23 17:09 yacn

I think this change has a typo in it? it just broke our chef runs... https://github.com/sous-chefs/java/blame/00570a6f0c07020186fae2aeedd2c49eb82d1e13/resources/openjdk_source_install.rb#L10 Should that be openjdk, not opendjdk?

mwiczynski-cartera avatar Sep 29 '23 17:09 mwiczynski-cartera

Hey all, this has been reverted, as mentioned on slack post on this, it was not indended to impact this PR and was due to bad automation. plans are in place to ensure this does nto happen again.

xorima avatar Oct 03 '23 08:10 xorima