faraday-http-cache icon indicating copy to clipboard operation
faraday-http-cache copied to clipboard
verified publisher icon sourcelevel

dependency on faraday_middleware, which is deprecated/obsolete

Open apteryks opened this issue 3 years ago • 2 comments

Hi,

According to https://github.com/lostisland/faraday_middleware/README.md, that component is deprecated and should be moved away from. Are there plans to do so for faraday-http-cache?

Thanks!

apteryks avatar Jan 09 '23 05:01 apteryks

I'll take a look. Thanks for the info.

Any updates I'll post here.

garaujodev avatar Jan 10 '23 01:01 garaujodev

Hello @Apteryks, sorry for my late reply.

faraday_middleware gem is only a development dependency when ENV['FARADAY_VERSION'] is set to <= 1.0, faraday-http-cache will pick the proper "Middleware" class according to Faraday version you're using dynamically.

https://github.com/sourcelevel/faraday-http-cache/blob/3f1bf705c9b6050cf48d382b33bc0ee402012ccd/lib/faraday/http_cache.rb#L351-L355

So it should work in all versions, but if you get any issue please let me know.

garaujodev avatar Mar 10 '23 18:03 garaujodev