src-cli icon indicating copy to clipboard operation
src-cli copied to clipboard

Support Perforce changelists in `src code-intel upload`

Open varungandhi-src opened this issue 2 years ago • 1 comments

Right now, there is a -commit flag, but if you try to pass a Perforce changelist, but the backend validates that the value is a Git hash.

unexpected status code: 400 (failed to enqueue payload: commit must be a 40-character revhash)

We should perhaps keep using the same flag, but have it allow passing a changelist instead.

In terms of design, perhaps we should require a cl:<blah> format (or similar) instead of accepting a bare identifier and then just assume that it is a changelist if it is not a 40-character hash. That way, we can add support for other formats later without having to have complicated inference logic.

varungandhi-src avatar Sep 04 '23 02:09 varungandhi-src

Requested by https://github.com/sourcegraph/accounts/issues/6938

mike-r-mclaughlin avatar Oct 02 '23 16:10 mike-r-mclaughlin