sourcegraph-typescript icon indicating copy to clipboard operation
sourcegraph-typescript copied to clipboard

Better way to handle go to defs when something goes wrong?

Open ryan-blunden opened this issue 7 years ago • 1 comments

I'm not sure if the odd behavior is due to the lang extension, the extension API or both, but wanted to document the behavior in any case.

I expected some indication that something went wrong so I know not to wait or try again.

I also expected that the hover would be dismissed after some arbitrary amount of time had passed.

screenflow

ryan-blunden avatar Jan 11 '19 02:01 ryan-blunden

Hmm I think this is because the extension polls the server for definitions, which it does because codeintellify will pre-fetch the definition and the server may not have analyzed the project yet. But I think it would be better behaviour to not poll and have the user trigger the action again, but I don't know if that would re-invoke the definition provider. @sqs do you know?

felixfbecker avatar Jan 11 '19 10:01 felixfbecker