sourcegraph-git-extras icon indicating copy to clipboard operation
sourcegraph-git-extras copied to clipboard

Incorrect hostname in commit link when using inline git blame functionality

Open zhuli19901106 opened this issue 6 years ago • 2 comments

Hi, I'm a software engineer from 4Paradigm, also a user of Sourcegraph.

I appreciate your wonderful product very much, which really helps me with code analysis.

I'd like to report a minor bug here.

As specified in the title, the URL always points to 127.0.0.1, while it's supposed to be the same hostname where it's deployed.

Setup info:

  • OS: Linux 4.4.166-1.el7.elrepo.x86_64 #1 SMP Sat Dec 1 10:48:24 EST 2018 x86_64 x86_64 x86_64 GNU/Linux
  • Installed via Docker image, tag=sourcegraph/server:3.8.2.
  • Private deployment on my own development server.
  • Use plugin, git-extras.

Inline commit message is correct, but generated URL points to 127.0.0.1:7080 instead of xxx (the host where I deployed it).

zhuli19901106 avatar Oct 29 '19 13:10 zhuli19901106

I have the same problem

Fazich avatar Nov 27 '19 12:11 Fazich

Well, I've spent 5 minutes to check the code and found this: image

Since I ran Sourcegraph from within docker, no wonder the hostname is 127.0.0.1.

I've never written typescript though, maybe I'll put in a fix later.

zhuli19901106 avatar Nov 29 '19 13:11 zhuli19901106