TestIntegration_FileSystem_Lint fails on windows

Open keegancsmith opened this issue 7 years ago • 4 comments

https://ci.appveyor.com/project/sourcegraph/go-langserver/builds/19433013#L40

2018/10/11 13:44:23 warning: lint command stderr: "warning: \"/C:/Users/appveyor/AppData/Local/Temp/1/langserver-go-integration705672984/gopath/src/test/p/...\" matched no packages\n"
--- FAIL: TestIntegration_FileSystem_Lint (10.07s)
    integration_test.go:518: Timeout while waiting for notification of type *lsp.PublishDiagnosticsParams
2018/10/11 13:45:37 refs.DefInfo: not a package-level definition (ident: x, object: var x map[string]test/pkg/a.A) and unable to follow type (type: map[string]test/pkg/a.A)

Oct 11 '18 14:10 keegancsmith

I wonder if this is a result of changing the pattern passed to golint to include rootFSPath (see #321).

I'm also not familiar with windows pathing, but it looks like the path is prefixed with an extra /.

Oct 11 '18 23:10 ianlopshire

Yeah windows is mysterious to me and I don’t have an env for it to iterate. I did quite a few attempts via appveyor to work it out, but gave up.

Oct 12 '18 03:10 keegancsmith

I think I can borrow a machine to look into this with. If I can find a solution I will submit a PR. I’ll provide an updated either way.

Oct 12 '18 07:10 ianlopshire

Thank you!!

Oct 12 '18 10:10 keegancsmith