conc icon indicating copy to clipboard operation
conc copied to clipboard

Use wg ctor

Open sashamelentyev opened this issue 3 years ago • 1 comments

sashamelentyev avatar Jan 07 '23 08:01 sashamelentyev

Codecov Report

Merging #25 (ac36b59) into main (d2e8f28) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          10       10           
  Lines         352      352           
=======================================
  Hits          350      350           
  Misses          2        2           
Impacted Files Coverage Δ
iter/iter.go 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jan 07 '23 08:01 codecov-commenter

@camdencheek what you think about this MR? Please tell if you don't want merge this - I close this

sashamelentyev avatar Jan 07 '23 21:01 sashamelentyev

@sashamelentyev I think I have a slight preference for var wg conc.WaitGroup in the code and examples because it better parallels the usage of sync.WaitGroup, so people recognize it as serving the same purpose.

camdencheek avatar Jan 07 '23 21:01 camdencheek

I agree. I close this

sashamelentyev avatar Jan 07 '23 21:01 sashamelentyev