checkup icon indicating copy to clipboard operation
checkup copied to clipboard

dns: domain must be fully qualified / or what does it do?

Open rrjanbiah opened this issue 5 years ago • 6 comments

Getting domain must be fully qualified error with:

{
  "type": "dns",
  "endpoint_name": "Testing DNS",
  "endpoint_url": "1.1.1.1:53", // cloudflare 
  "hostname_fqdn": "foo.com"
}

While Googling the error it seems to suggest that it is trying to update DNS (which I don't want). So, what does it exactly do?

rrjanbiah avatar May 21 '20 08:05 rrjanbiah

The fully qualified domain name consists of three or more labels: The top level domain, the domain names, optional subdomains, and the host name.

So, from what I understand, a www.foo.com should be a fqdn, while foo.com is not. You could try with foo.com. (trailing dot), but i'm not sure that it's going to work.

titpetric avatar May 21 '20 09:05 titpetric

https://ut.service-now.com/sp?id=kb_article&number=KB0011254

titpetric avatar May 21 '20 09:05 titpetric

@titpetric Thank you so much for your quick reply. So, is it different from nslookup? IOW, is it to check if the given hostname is resolving? TIA

rrjanbiah avatar May 21 '20 10:05 rrjanbiah

Also, for the sake of record trailing dot fixed it.

rrjanbiah avatar May 21 '20 10:05 rrjanbiah

What can we do better?

  • don’t require a fqdn (a less strict check),
  • assert resolved ips against []string list of IPs,
  • check ipv6 options (AAAA record)

If you have other suggestions, please add a comment with a related feature request for the dns checker, or a new issue if a different area of checkup

On Thu, 21 May 2020 at 12:14, R. Rajesh Jeba Anbiah < [email protected]> wrote:

Also, for the sake of record trailing dot fixed it.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sourcegraph/checkup/issues/126#issuecomment-632004316, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABY7ECIK75FFSQI65XDPJLRST5IZANCNFSM4NGVJEAQ .

titpetric avatar May 21 '20 10:05 titpetric

@titpetric I think, current checks are perfectly fine. Some doc or sample config will suffice, IMHO.

rrjanbiah avatar May 21 '20 10:05 rrjanbiah