about icon indicating copy to clipboard operation
about copied to clipboard

Extend Video component for source prop

Open zlonko opened this issue 3 years ago • 1 comments

Refactor filePath to source to allow for wider implementation (e.g., blogposts).

Context from review

Example:

interface Video {
  source: {
    webm: string
    mp4: string
  }
  loop: boolean
  caption: string
  title: string
}

Also, please identify opportunities to cut the blog SCSS out into Bootstrap utility classes. (Reference)

zlonko avatar Jun 20 '22 17:06 zlonko

It looks like component and interface were updated in https://github.com/sourcegraph/about/pull/5548. We can still use this issue to clean up the blog SCSS where possible!

zlonko avatar Jun 30 '22 22:06 zlonko

The Video component updates were updated in #5493. Other styling initiatives will be tackled in #5381.

bretthayes avatar Oct 17 '22 18:10 bretthayes