sourcegit icon indicating copy to clipboard operation
sourcegit copied to clipboard

code_style: general cleanup

Open NathanBaulch opened this issue 6 months ago • 2 comments

Various code improvements. The changes to QueryLocalChanges in particular make the code much easier to understand.

NathanBaulch avatar Jul 11 '25 11:07 NathanBaulch

I no longer plan to merge this kind of PR.

  1. There are too many code changes, which takes too much time to review.
  2. Sometimes I can't recall the issues that needed to be considered during the coding process, resulting in bugs, such as #1582, #1576, d28bd92e4f68f6e406aa093ed786b8bede68331f, etc.
  3. Most of them are about new syntax or variable initialization suggestions.

love-linger avatar Jul 15 '25 06:07 love-linger

No worries, I only submitted this because you were so quick and thorough at reviewing previous cleanup PRs. I wasn't aware there had been regressions.

NathanBaulch avatar Jul 15 '25 06:07 NathanBaulch