Martin Pool

Results 258 comments of Martin Pool

I guess this is your [`rustybug`?](https://github.com/xd009642/rustybug)? I thought I'd try that as a potentially simpler reproduction but unfortunately `cargo test` also fails for me there, after building the test programs....

Hi @ASuciuX This sounds like https://github.com/sourcefrog/cargo-mutants/issues/117 but I guess you are already using >25.0.0 that includes that fix? If you can narrow this down to a specific failure that will...

> I haven’t fully investigated the root cause or a potential underlying solution, but I found that using --in-place is preferable for CI regardless. Separately from this bug: yes, that...

> * The copy containing the `target` still fails without `--in-place` and works with `--in-place`. Interesting. If it's not the copying then I guess the problem is with the manifest...

OK the failure is pretty apparent in https://github.com/hirosystems/ordhook/actions/runs/13164203008/job/36740241226#step:9:986, > --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/p256k1-7.2.2/src/_rename.rs:10:5 > error[E0432]: unresolved imports `crate::bindings::s2bca0a5cbf756dd4ff1f0bda4585a7d3c64e1480_secp256k1_context_preallocated_clone`, `crate::bindings::s2bca0a5cbf756dd4ff1f0bda4585a7d3c64e1480_secp256k1_context_preallocated_clone_size`, `crate::bindings::s2bca0a5cbf756dd4ff1f0bda4585a7d3c64e1480_secp256k1_context_preallocated_create`, `crate::bindings::s2bca0a5cbf756dd4ff1f0bda4585a7d3c64e1480_secp256k1_context_preallocated_destroy`, `crate::bindings::s2bca0a5cbf756dd4ff1f0bda4585a7d3c64e1480_secp256k1_context_preallocated_size` These names come from https://github.com/Trust-Machines/p256k1/blob/master/p256k1/src/bindings.rs I notice that in this...

#454 says we perhaps shouldn't skip gitignored files by default, because it saves a bit of time copying but might cause confusing errors when the tree depends on gitignored files....

With `--gitignore=true` (currently the default) it just does not copy them into the temp dirs: https://github.com/sourcefrog/cargo-mutants/blob/debd7cbb5e8a95353e008246139333aacc8269a3/src/copy_tree.rs#L46-L60

`gitignore` filtering is now off by default (through #454) so I think this is closed.

I think this is still very feasible, but I'm going to close it for now, because I'm not likely to proactively work on it unless or until there is both:...