source-academy
Fix and Improve Ground Control
Description
The mutable state should have been migrated to use useRef when the component was transitioned to a functional component.
This was a regression introduced in #2875.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Code quality improvements
How to test
It should now work, aka fixes this bug:
Checklist
- [x] I have tested this code
- [ ] I have updated the documentation
Pull Request Test Coverage Report for Build 9052848283
Details
- 0 of 29 (0.0%) changed or added relevant lines in 2 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.01%) to 31.581%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/pages/academy/academyRoutes.tsx | 0 | 1 | 0.0% |
| src/pages/academy/groundControl/GroundControl.tsx | 0 | 28 | 0.0% |
| <!-- | Total: | 0 | 29 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/pages/academy/groundControl/GroundControl.tsx | 1 | 0.0% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 9052785407: | -0.01% |
| Covered Lines: | 4921 |
| Relevant Lines: | 14701 |
💛 - Coveralls
For some reason the table still looks the way it does. We might need to take a closer look at it
For some reason the table still looks the way it does. We might need to take a closer look at it
Hmm, I see, alright, I'll take a closer look over the next few days. Thanks!
For some reason the table still looks the way it does. We might need to take a closer look at it
The issue is now fixed in #3001. But I'm keeping this PR open for some further improvements.