nmos-cpp icon indicating copy to clipboard operation
nmos-cpp copied to clipboard

Call set_transportfile for senders and receivers

Open aholzinger opened this issue 5 years ago • 2 comments

Streaming implementations that use SDP to configure (create objects, set internal state) also for receivers need the information in the SDP. Why not call set_transportfile also for receivers (and not only for senders)?

With this patch https://github.com/aholzinger/nmos-cpp/commit/6462671cf29ac8e41d3b664e9444c648f622b877 this is possible.

aholzinger avatar Mar 11 '20 10:03 aholzinger

I understand the desire to update the Receiver's current internal configuration with new transport parameters in the /active "transport_params" (and/or media parameters that have come via the /active "transport_file") and possibly store this as an SDP file.

However, IS-05 Receivers do not have the /transportfile endpoint, so the nmos::node_model::connection_resources data model is not intended to retain an SDP file for the Receiver (apart from the one(s) that may have been set into the "transport_file" props of the /staged and /active endpoints).

I think you can achieve what you want as your last action in a resolve_auto callback?

garethsb avatar Mar 11 '20 11:03 garethsb

I'm currently trying to sort out why I made this patch (could be that it's not anymore needed in my code anyhow and is just a remnant, because my set_transportfile callback isn't actually doing anything meaningful in case it has been calld for a receiver). I'll report back. Sorry for the noise.

aholzinger avatar Mar 15 '20 13:03 aholzinger