sonic-linux-kernel icon indicating copy to clipboard operation
sonic-linux-kernel copied to clipboard

Fix some emmc unreliability seen on older AMD CPUs

Open Staphylo opened this issue 3 years ago • 2 comments

Some patches are required to fix some emmc unreliability seen on AMD platforms. These were ported over from the EOS kernel and applied properly.

Staphylo avatar Feb 17 '22 16:02 Staphylo

@Staphylo, any updates?

paulmenzel avatar Jun 07 '22 08:06 paulmenzel

@Staphylo Can you also do easyCLA?

sujinmkang avatar Sep 09 '22 23:09 sujinmkang

@Staphylo can you rebase this onto the current master branch so that we can get this merged onto the master branch, and cherry-picked for 202211?

saiarcot895 avatar Jan 26 '23 21:01 saiarcot895

I just rebased my changes on top of master.

As a side note, if my change to drivers/mmc/host/sdhci-pci-core.c is seen as too dangerous, I could leverage the append_quirk* change to encode all the necessary quirks via the cmdline for the affected product only.

sdhci.append_quirk=0x20 sdhci.append_quirk2=0x240

It would amount to enabling:

  • SDHCI_QUIRK_BROKEN_ADMA
  • SDHCI_QUIRK2_BROKEN_64_BIT_DMA
  • SDHCI_QUIRK2_BROKEN_HS200

Staphylo avatar Jan 31 '23 16:01 Staphylo

@prgeor for visibility

Staphylo avatar Feb 03 '23 13:02 Staphylo

Are there plans to upstream, at minimum, patch/driver-arista-mmcblk-not-working-on-AMD-platforms.patch?

saiarcot895 avatar Feb 07 '23 20:02 saiarcot895

Are there plans to upstream, at minimum, patch/driver-arista-mmcblk-not-working-on-AMD-platforms.patch?

There is currently no plan to upstream this. As mentioned in my previous comment, if that's a problem for you I could do everything via kernel parameters and drop driver-arista-mmcblk-not-working-on-AMD-platforms.patch

Staphylo avatar Feb 09 '23 10:02 Staphylo

@Staphylo please help create an PR for 202205 branch.

yxieca avatar Feb 09 '23 22:02 yxieca

@saiarcot895 @xumia could we enable default PR format for this repo? Like PR need to include below info.

Why I did it How I did it How to verify it

StormLiangMS avatar Feb 10 '23 15:02 StormLiangMS

@yxieca this fix is already on 202205. The only diff is in the patch description since I added a few lines here. I don't think there's anything to do for 202205.

Staphylo avatar Feb 10 '23 16:02 Staphylo