codestyle icon indicating copy to clipboard operation
codestyle copied to clipboard

Update Eclipse codestyle to wrap generics one per line

Open mpiggott opened this issue 9 months ago • 2 comments

The current code style does not allow wrapping of generics leading to run-on lines, this updates the style to allow the original layout.

-public abstract class FormatStoreModule<CONTENT_REPOSITORY_DAO extends ContentRepositoryDAO,
-                                        COMPONENT_DAO extends ComponentDAO,
-                                        ASSET_DAO extends AssetDAO,
-                                        ASSET_BLOB_DAO extends AssetBlobDAO>
+public abstract class FormatStoreModule<CONTENT_REPOSITORY_DAO extends ContentRepositoryDAO, COMPONENT_DAO extends ComponentDAO, ASSET_DAO extends AssetDAO, ASSET_BLOB_DAO extends AssetBlobDAO>
 
-    extends BespokeFormatStoreModule<ContentRepositoryStore<CONTENT_REPOSITORY_DAO>,
-                                     ComponentStore<COMPONENT_DAO>,
-                                     AssetStore<ASSET_DAO>,
-                                     AssetBlobStore<ASSET_BLOB_DAO>>
+    extends
+    BespokeFormatStoreModule<ContentRepositoryStore<CONTENT_REPOSITORY_DAO>, ComponentStore<COMPONENT_DAO>, AssetStore<ASSET_DAO>, AssetBlobStore<ASSET_BLOB_DAO>>
 {
   // nothing to add...
 }

I've sorted the export and made no other manual changes but this may be related to a newer version of Eclipse (the profiles version switched from 13 to 23).

mpiggott avatar Apr 29 '25 17:04 mpiggott

I haven't yet found a setting for the second part where extends is also really long.

mpiggott avatar Apr 29 '25 17:04 mpiggott

I see lots of new configuration values added that appear un-related to the change you were targeting. Should we remove them? I'm somewhat concerned it may cause a lot of formatting changes going forward.

This is what I was referencing for profiles version (e.g. <profiles version="23">). It would appear this file was created quite some time ago and my guess is that the current version of Eclipse uses a newer revision of the file. So import -> export results in some data migration. (After I saw the diff, I re-imported the original file, made the same change and exported it with the same result)

mpiggott avatar Apr 30 '25 15:04 mpiggott