[Admin] adding new shipping category
Summary
This PR migrates the creation of new shipping categories to the new admin interface. It follows the same kind of work done for Tax categories in https://github.com/solidusio/solidus/pull/5674 There is no issue but a project item that I cannot move or comment, probably due to permission issues. https://github.com/orgs/solidusio/projects/12/views/1?filterQuery=xs&pane=issue&itemId=52590587
I also fixed searching shipping categories. This was a feature not present on old admin and by introducing new UI, and capability to search them, it was missing a ransack config to allow searching them by name.
https://github.com/solidusio/solidus/assets/824936/5b258fb0-fc87-4238-84f4-56d6fc838cbf
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
- [x] I have written a thorough PR description.
- [x] I have kept my commits small and atomic.
- [x] I have used clear, explanatory commit messages.
The following are not always needed:
Thanks @loicginoux! I created https://github.com/solidusio/solidus/issues/5720 to attach to this PR, thanks again!
Not sure about the failing linter CI step. Should I look into it or is it something with the CI ? The error does not look like specific to this PR...
The error seems to be related to ESLint in the CI. I you want to take a look at it with another PR, you are more than welcome, thanks Loic!
I just rebased branch from main after the linting CI error has been fixed in https://github.com/solidusio/solidus/pull/5721. CI should be green here after that.
Codecov Report
Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 88.86%. Comparing base (
3f6c58c) to head (55ec39e).
| Files | Patch % | Lines |
|---|---|---|
| ...rs/solidus_admin/shipping_categories_controller.rb | 96.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #5718 +/- ##
==========================================
+ Coverage 88.84% 88.86% +0.02%
==========================================
Files 704 705 +1
Lines 16757 16789 +32
==========================================
+ Hits 14887 14919 +32
Misses 1870 1870
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.