Replace deprecated RubaXa-Sortable component to mainstream Sortable.js

Open webhive opened this issue 5 years ago • 1 comments

Found Solidus using outdated fork of Sortable.js

This is component used as Sortable now https://github.com/components/RubaXa-Sortable The only reason of existing of RubaXa-Sortable fork is composer support what is really a PHP feature and odes not related to Rails.

Anyway this fork was already merged to mainstream - see pull request here https://github.com/SortableJS/sortablejs/pull/1203

So it could be great to just replace it with mainstream version.

Oct 23 '20 12:10 webhive

Interesting catch, thanks!

I'm not able to find any documentation about the differences between those forks, can you link something, please?

Also, this is the PR that introduced the library, just for reference: https://github.com/solidusio/solidus/pull/2523.

Nov 04 '20 14:11 kennyadsl