solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard
verified publisher icon solidjs

Routes exporting both API endpoints and a component are not code split for client/server.

Open ghalle opened this issue 3 years ago • 1 comments

This can cause issues when using dependencies that are not meant to be used on the client.

I suspect it might also leak the source for the API endpoints, but I have yet to confirm it.

We probably need to apply a babel transform to separate the API endpoints from the component.

ghalle avatar Oct 16 '22 04:10 ghalle

yeah we should just remove it from the client bundle

nksaraf avatar Oct 16 '22 06:10 nksaraf

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed in mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.

ryansolid avatar Dec 18 '23 21:12 ryansolid