fix: handle deleted cookies in single flight request
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] Addresses an existing open issue: fixes #1863
- [ ] Tests for the changes have been added (for bug fixes / features)
What is the current behavior?
#1863 Right now cookies are not deleted in single flight requests
What is the new behavior?
Cookies are deleted in single flight requests
Other information
cookie-es is added as a explicit dependency, but it's what h3 uses internally.
https://github.com/unjs/h3/blob/main/src/utils/cookie.ts#L69
Here's parseSetCookie for reference. https://github.com/unjs/cookie-es/blob/main/src/set-cookie/parse.ts
⚠️ No Changeset found
Latest commit: 587668cba20e46f976a7420e9d14521b21918816
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Deploy Preview for solid-start-landing-page ready!
| Name | Link |
|---|---|
| Latest commit | 587668cba20e46f976a7420e9d14521b21918816 |
| Latest deploy log | https://app.netlify.com/sites/solid-start-landing-page/deploys/67de12f4f626c20008553517 |
| Deploy Preview | https://deploy-preview-1864--solid-start-landing-page.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@zhengkyl can you fix the conflicts?
couldn't push the conflict fixing and the changesets to this one, so merged the commits to #1970