solid-site icon indicating copy to clipboard operation
solid-site copied to clipboard
verified publisher icon solidjs

Fix meta pwa

Open Brian-Pob opened this issue 1 year ago • 2 comments

Multiple improvements

  • clean up meta tags in index.html
    • removing repeated tags
    • adding correct tag attributes
    • property= instead of name= for some tags as per OG protocol
  • implement PWA functionality
    • I noticed there was an attempt to include PWA functionality before.
    • uses vite-plugin-pwa as it was already part of the dependencies
  • added images for PWA functionality
    • used the existing icons located in public/img/icons
    • does not explicitly set PWA options for Android or iOS yet
    • screenshot images were taken using Arc browser's screenshot tool
    • I can use different images if requested

Brian-Pob avatar Mar 28 '24 07:03 Brian-Pob

Tried deploying my fork onto CF pages and Vercel and couldn't get either to work. :( It does work when I run pnpm dev but running build reveals some errors that I don't know how to fix.

This is the error that pops up whenever build is executed

Cannot use 'in' operator to search for 'children' in undefined
file: .../solid-site-fix-meta/src/pages/Articles/state-of-solid-december-2021.mdx

Edit: Fixed this in 86b3d51

Brian-Pob avatar Mar 28 '24 07:03 Brian-Pob

CFP Preview link https://4748970c.solid-site-fix-meta.pages.dev/

Brian-Pob avatar Apr 02 '24 08:04 Brian-Pob