solid-router icon indicating copy to clipboard operation
solid-router copied to clipboard

Improve test coverage in data functions

Open atilafassina opened this issue 3 months ago • 1 comments

PR looks big because of the number of mocks and tests added. Logic change is quite small.


  • [x] action
  • [x] createAsync
  • [x] events
  • [x] query
  • [x] response

There are some formatting changes. It's worth to consider adding a linter config on a later PR.

Touched some logic

Tests pointed out that action and createAsync were not respecting user defined name. Moreover, action was not applying the hashed name and only naming the action "mutate", I believe my changes brought it closer to original intentions, but I can revert them otherwise.

atilafassina avatar Nov 09 '25 15:11 atilafassina

🦋 Changeset detected

Latest commit: 63940c53467d990b6d86ebeab291ffbf0a631581

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 09 '25 15:11 changeset-bot[bot]