feat: Add zio-http multipart body support
Resolves #2518
Currently tests fail because the incoming ServerRequest contains the multiple parts, but when calling zio.http.Request.body.[asMultipartFormStream|asMultiPartForm] they only ever return the single, first part.
Seems to be a bug in zio-http: https://github.com/zio/zio-http/issues/2411
Bug was fixed and released. I have let the build run in my own actions and it succeded: https://github.com/seakayone/tapir/actions/runs/9943391610
@seakayone now that https://github.com/softwaremill/tapir/pull/3690 is merged, can you put up this PR for review?
I am planning to finalize this PR in the next couple of days hopefully.
There's some problems updating ZIO, I think we'll need to first tackle https://github.com/softwaremill/tapir/pull/3876/, and then get back to this PR. Sorry for the problems :)
Found the problem in zio-http: https://github.com/zio/zio-http/issues/2977
Hello. Any news on this one and #3876 ? Really eager to start using multipart requests -_-
@seakayone zio/zio-http#2977 was closed
@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!
@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!
I'm guessing it's the same reason
@resilica @geeeezmo yes, unfortunately RC9 had a bug which prevented the update, there's another one now in RC10.
@seakayone can this PR be made public so it can be reviewed?
Because #4034 that updates zio-http to 3.0.0 has been merged.
Thanks for the work, needed a little push to get over the finish line, tests are now green :)
Thank you, Adam, for all the work you do. Can't wait for the next release 🙃
@adamw Thanks for finalizing this.