tapir icon indicating copy to clipboard operation
tapir copied to clipboard

feat: Add zio-http multipart body support

Open seakayone opened this issue 1 year ago • 7 comments

Resolves #2518

Currently tests fail because the incoming ServerRequest contains the multiple parts, but when calling zio.http.Request.body.[asMultipartFormStream|asMultiPartForm] they only ever return the single, first part.

Seems to be a bug in zio-http: https://github.com/zio/zio-http/issues/2411

Bug was fixed and released. I have let the build run in my own actions and it succeded: https://github.com/seakayone/tapir/actions/runs/9943391610

seakayone avatar Apr 16 '24 13:04 seakayone

@seakayone now that https://github.com/softwaremill/tapir/pull/3690 is merged, can you put up this PR for review?

godspeedelbow avatar Jun 24 '24 04:06 godspeedelbow

I am planning to finalize this PR in the next couple of days hopefully.

seakayone avatar Jul 10 '24 09:07 seakayone

There's some problems updating ZIO, I think we'll need to first tackle https://github.com/softwaremill/tapir/pull/3876/, and then get back to this PR. Sorry for the problems :)

adamw avatar Jul 23 '24 20:07 adamw

Found the problem in zio-http: https://github.com/zio/zio-http/issues/2977

adamw avatar Jul 24 '24 14:07 adamw

Hello. Any news on this one and #3876 ? Really eager to start using multipart requests -_-

@seakayone zio/zio-http#2977 was closed

alexander-klimov avatar Aug 09 '24 16:08 alexander-klimov

@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!

resilica avatar Aug 20 '24 11:08 resilica

@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!

I'm guessing it's the same reason

geeeezmo avatar Aug 27 '24 17:08 geeeezmo

@resilica @geeeezmo yes, unfortunately RC9 had a bug which prevented the update, there's another one now in RC10.

adamw avatar Sep 02 '24 14:09 adamw

@seakayone can this PR be made public so it can be reviewed? Because #4034 that updates zio-http to 3.0.0 has been merged.

alexander-klimov avatar Sep 11 '24 10:09 alexander-klimov

Thanks for the work, needed a little push to get over the finish line, tests are now green :)

adamw avatar Sep 17 '24 09:09 adamw

Thank you, Adam, for all the work you do. Can't wait for the next release 🙃

alexander-klimov avatar Sep 17 '24 09:09 alexander-klimov

@adamw Thanks for finalizing this.

seakayone avatar Sep 18 '24 10:09 seakayone