tapir icon indicating copy to clipboard operation
tapir copied to clipboard

zio-http multipart support

Open lvitaly opened this issue 2 years ago • 5 comments

https://github.com/softwaremill/tapir/issues/2518 https://github.com/softwaremill/tapir/issues/1595

lvitaly avatar Aug 17 '23 12:08 lvitaly

Hello, thanks for the effort in this I know It's is in draft mode, but I tried to add your changes and tested. For smaller files (~50-60KB) it works fine but for more it gives 413 (Request Entity Too Large). So is that the reason you have it in draft more (And you are trying to resolve this) OR there is some more stuff that i am unaware of ?

zeffd avatar Aug 22 '23 16:08 zeffd

@zeffd That might be the default streaming request size of zio-http server (100 KB). You can change it via Server.Config (see here)

geeeezmo avatar Aug 22 '23 19:08 geeeezmo

Also, would be great for this PR to gain some traction as this is a much needed feature :)

geeeezmo avatar Aug 22 '23 19:08 geeeezmo

@zeffd That might be the default streaming request size of zio-http server (100 KB). You can change it via Server.Config (see here)

Yes thanks it works now 👍

zeffd avatar Aug 23 '23 04:08 zeffd

@zeffd, unfortunately, this is a naive implementation of the multipart. It works correctly for file upload, but tests for multipart forms fail with status code 400. I need to figure out what's wrong there.

lvitaly avatar Aug 23 '23 07:08 lvitaly

Closing old PRs

adamw avatar Apr 03 '24 08:04 adamw

Has this been already implemented in another PR?

geeeezmo avatar Apr 04 '24 22:04 geeeezmo

@geeeezmo no, multipart support is still lacking for zio http. Though zio http APIs change so much that I suppose you'd need to start from scratch anyway ;)

adamw avatar Apr 05 '24 07:04 adamw